|
Description
Kyle M Hall (khall)
2018-01-17 19:29:26 UTC
Created attachment 70635 [details] [review] Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Created attachment 70636 [details] [review] Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Created attachment 71401 [details] [review] Bug 20008 - Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 71405 [details] [review] Bug 20008: Fix restrictions added from memberentry.pl if TimeFormat is 12hr Test Plan: 1) Set TimeFormat to 12 hour 2) Add a restriction with an expiration date via memberentry.pl 3) Note the restriction exists, but has no expiration date 4) Apply this patch 5) Repeat step 2 6) Note the restriction exists and has an expiration date! Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> It seems that we must be the module instead. Kyle can you take a look at bug 20178 and tell me if the patch fixes your issue? *** This bug has been marked as a duplicate of bug 20178 *** I will reevaluate this later but I think we should provide a global solution, see bug 20178. This patch is not perfect but fixes the problem. I still think it must be fixed globally. Pushed to master for 18.05, thanks to everybody involved! Pushed to 17.11.x for 17.11.08 |