Bug 20010

Summary: use Modern::Perl in Patroncards perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: Grace <gracesmythh>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2505    
Attachments: Bug 20010: use Modern::Perl in Patroncards perl scripts
Bug 20010: use Modern::Perl in Patroncards perl scripts
Bug 20010: use Modern::Perl in Patroncards perl scripts
Bug 20010: use Modern::Perl in Patroncards perl scripts

Description Aleisha Amohia 2018-01-17 19:45:40 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
create-pdf.pl
edit-batch.pl
edit-layout.pl
edit-profile.pl
edit-template.pl
home.pl
image-manage.pl
manage.pl
print.pl
Comment 1 Grace 2018-01-18 04:01:36 UTC
Created attachment 70680 [details] [review]
Bug 20010: use Modern::Perl in Patroncards perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

create-pdf.pl
edit-batch.pl
edit-layout.pl
edit-profile.pl
edit-template.pl
home.pl
image-manage.pl
manage.pl
print.pl
Comment 2 Jon Knight 2018-01-24 18:26:11 UTC
Created attachment 70888 [details] [review]
Bug 20010: use Modern::Perl in Patroncards perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

create-pdf.pl
edit-batch.pl
edit-layout.pl
edit-profile.pl
edit-template.pl
home.pl
image-manage.pl
manage.pl
print.pl
Comment 3 Jon Knight 2018-01-24 18:34:15 UTC
Created attachment 70891 [details] [review]
Bug 20010: use Modern::Perl in Patroncards perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

create-pdf.pl
edit-batch.pl
edit-layout.pl
edit-profile.pl
edit-template.pl
home.pl
image-manage.pl
manage.pl
print.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Comment 4 Katrin Fischer 2018-02-04 13:33:26 UTC
Created attachment 71189 [details] [review]
Bug 20010: use Modern::Perl in Patroncards perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

create-pdf.pl
edit-batch.pl
edit-layout.pl
edit-profile.pl
edit-template.pl
home.pl
image-manage.pl
manage.pl
print.pl

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-02-05 12:59:27 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-02-16 00:59:08 UTC
Awesome work all! Enhancement not backported to stable.