Bug 20013

Summary: use Modern::Perl in Reserves perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: jwayway
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2505    
Attachments: Bug-20013: use Modern::Perl in Reserve perl script
Bug-20013: use Modern::Perl in Reserve perl script
Bug 20013: use Modern::Perl in Reserve perl script

Description Aleisha Amohia 2018-01-17 19:49:57 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
modrequest.pl
modrequest_suspendall.pl
placerequest.pl
Comment 1 jwayway 2018-01-18 00:43:47 UTC
Created attachment 70655 [details] [review]
Bug-20013: use Modern::Perl in Reserve perl script

Test plan:
Check the following files that use strict; use warnings; doesn't exist
and use Modern::Perl; is written instead.
modrequest.pl
modrequest_suspendall.pl
placerequest.pl
Comment 2 Owen Leonard 2018-01-23 12:55:09 UTC
Created attachment 70824 [details] [review]
Bug-20013: use Modern::Perl in Reserve perl script

Test plan:
Check the following files that use strict; use warnings; doesn't exist
and use Modern::Perl; is written instead.
modrequest.pl
modrequest_suspendall.pl
placerequest.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2018-02-04 13:26:15 UTC
Created attachment 71185 [details] [review]
Bug 20013: use Modern::Perl in Reserve perl script

Test plan:
Check the following files that use strict; use warnings; doesn't exist
and use Modern::Perl; is written instead.
modrequest.pl
modrequest_suspendall.pl
placerequest.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-02-05 12:59:45 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2018-02-16 01:00:16 UTC
Awesome work all! Enhancement not backported to stable.