Summary: | use Modern::Perl in svc scripts | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Architecture, internals, and plumbing | Assignee: | Zoe Bennett <zoebennett1308> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | mtompset, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 2505 | ||
Attachments: |
Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;'
Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Bug 20016: use Modern::Perl in svc scripts |
Description
Aleisha Amohia
2018-01-17 20:00:52 UTC
Created attachment 70671 [details] [review] Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib Created attachment 70899 [details] [review] Bug 20011: Changing 'use strict; use warnings;' to 'use Modern::Perl;' Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Jon Knight signed a patch supplied by Zoe Bennett. It looks good to me too. Changing to signed off, since I think that was just a forgotten step. Created attachment 71183 [details] [review] Bug 20016: use Modern::Perl in svc scripts Test Plan: - Check that it now says 'use Modern::Perl' and not 'use trict; use warnings;' in the follwing plugins svc scripts authentication bib bib_profile checkouts config/systempreferences import_bib new_bib https://bugs.koha-community.org/show_bug.cgi?id=20016 Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Enhancement not backported to stable. |