Bug 20017

Summary: use Modern::Perl in Tools perl scripts
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: Architecture, internals, and plumbingAssignee: jwayway
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: J.P.Knight, jonathan.druart+koha, katrin.fischer, nick
Version: unspecifiedKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 2505, 20305    
Attachments: Bug-29917: use Modern::Perl in Tools perl scripts
Bug-29917: use Modern::Perl in Tools perl scripts
Bug 20017: use Modern::Perl in Tools perl scripts

Description Aleisha Amohia 2018-01-17 20:02:47 UTC
use Modern::Perl should be used instead of use strict; use warnings;

Relevant in:
background-job-progress.pl
batchMod.pl
copy-holidays.pl
exceptionHolidays.pl
holidays.pl
import_borrowers.pl
koha-news.pl
letter.pl
manage-marc-import.pl
newHolidays.pl
overduerules.pl
quotes-upload.pl
quotes.pl
quotes/quotes-upload_ajax.pl
quotes/quotes_ajax.pl
scheduler.pl
stage-marc-import.pl
upload-cover-image.pl
Comment 1 jwayway 2018-01-18 02:11:18 UTC
Created attachment 70664 [details] [review]
Bug-29917: use Modern::Perl in Tools perl scripts

Test plan:
Check that the following files don't contain use strict; use warnings;
and have use Modern::Perl instead.
background-job-progress.pl
batchMod.pl
copy-holidays.pl
exceptionHolidays.pl
holidays.pl
import_borrowers.pl
koha-news.pl
letter.pl
manage-marc-import.pl
newHolidays.pl
overduerules.pl
quotes-upload.pl
quotes.pl
quotes/quotes-upload_ajax.pl
quotes/quotes_ajax.pl
scheduler.pl
stage-marc-import.pl
upload-cover-image.pl

Also the credits have been added to newHolidays.pl
Comment 2 Jon Knight 2018-01-24 18:50:31 UTC
Created attachment 70900 [details] [review]
Bug-29917: use Modern::Perl in Tools perl scripts

Test plan:
Check that the following files don't contain use strict; use warnings;
and have use Modern::Perl instead.
background-job-progress.pl
batchMod.pl
copy-holidays.pl
exceptionHolidays.pl
holidays.pl
import_borrowers.pl
koha-news.pl
letter.pl
manage-marc-import.pl
newHolidays.pl
overduerules.pl
quotes-upload.pl
quotes.pl
quotes/quotes-upload_ajax.pl
quotes/quotes_ajax.pl
scheduler.pl
stage-marc-import.pl
upload-cover-image.pl

Also the credits have been added to newHolidays.pl

https://bugs.koha-community.org/show_bug.cgi?id=20017
Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Comment 3 Katrin Fischer 2018-02-04 13:14:46 UTC
Created attachment 71182 [details] [review]
Bug 20017: use Modern::Perl in Tools perl scripts

Test plan:
Check that the following files don't contain use strict; use warnings;
and have use Modern::Perl instead.
background-job-progress.pl
batchMod.pl
copy-holidays.pl
exceptionHolidays.pl
holidays.pl
import_borrowers.pl
koha-news.pl
letter.pl
manage-marc-import.pl
newHolidays.pl
overduerules.pl
quotes-upload.pl
quotes.pl
quotes/quotes-upload_ajax.pl
quotes/quotes_ajax.pl
scheduler.pl
stage-marc-import.pl
upload-cover-image.pl

Also the credits have been added to newHolidays.pl

https://bugs.koha-community.org/show_bug.cgi?id=20017
Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Comment 4 Katrin Fischer 2018-02-04 13:15:28 UTC
Good job! Please always be careful to put the right bug number in the commit message as this will be used to generate the release notes. Fixed it here.
Comment 5 Jonathan Druart 2018-02-05 12:37:53 UTC
(In reply to Katrin Fischer from comment #3)
> Also the credits have been added to newHolidays.pl

But not the good one. I am going to amend the patch to remove this part.
Comment 6 Jonathan Druart 2018-02-05 13:00:05 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 7 Nick Clemens 2018-02-16 01:00:58 UTC
Awesome work all! Enhancement not backported to stable.