Summary: | use Modern::Perl in t (test) perl scripts | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Architecture, internals, and plumbing | Assignee: | Aleisha Amohia <aleisha> |
Status: | Patch doesn't apply --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, J.P.Knight, maryse.simard |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 20022 - use Modern::Perl in t (test) perl scripts
Bug 20022 - use Modern::Perl in t (test) perl scripts |
Description
Aleisha Amohia
2018-01-17 20:20:04 UTC
Created attachment 70717 [details] [review] Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_annual.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t smolder_smoke_signal :) Appears to be missing 'use Modern::Perl;' in: t/Barcodes_annual.t Created attachment 83857 [details] [review] Bug 20022 - use Modern::Perl in t (test) perl scripts Test Plan: Check the following files have been updated from use strict; use warnings; to use Modern::Perl; 00-checkdatabase-version.t 00-deprecated.t 00-valid-xml.t AuthoritiesMarc_MARC21.t AuthoritiesMarc_UNIMARC.t Barcodes_EAN13.t Barcodes_hbyymmincr.t Barcodes_incremental.t Bookseller.t Budgets.t ClassSortRoutine.t ClassSortRoutine_Dewey.t ClassSortRoutine_Generic.t ClassSortRoutine_LCC.t ClassSource.t Contract.t Creators.t EdiInvoice.t Edifact.t Ediorder.t Ediordrsp.t External/Syndetics.t Form_MessagingPreferences.t Heading.t HtmlTags.t Installer_PerlDependencies.t Installer_pm.t ItemCirculationAlertPreference.t Koha_Util_MARC.t Labels.t Labels_split_ccn.t Labels_split_ddcn.t Labels_split_lccn.t Log.t Members_Attributes.t Members_Messaging.t Output.t Output_JSONStream.t Patroncards.t Patroncards_Batch.t Patroncards_Layout.t Patroncards_Lib.t Patroncards_Patroncard.t Patroncards_Profile.t Patroncards_Template.t Print.t QueryParser.t Scheduler.t Scrubber.t Stats.t SuggestionEngine.t TmplToken.t db_dependent/00-strict.t db_dependent/Amazon.t db_dependent/Heading_MARC21.t db_dependent/LDAP/test_ldap_add.pl db_dependent/Languages.t db_dependent/MungeMarcPrice.t db_dependent/Record/Record.t db_dependent/RecordProcessor_EmbedSeeFromHeadings.t db_dependent/Reports.t db_dependent/Service.t db_dependent/SuggestionEngine_ExplodedTerms.t db_dependent/Tags.t :) (In reply to Jon Knight from comment #2) > Appears to be missing 'use Modern::Perl;' in: > > t/Barcodes_annual.t The reason this was skipped is because there is no use strict; use warnings; so we don't want to add them if they're not already being used. It was likely accidentally added to the commit message. Patch has been rebased and is ready to test. Patch no longer applies. |