Bug 20031

Summary: CGI param in list context warn in guided_reports.pl
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: jonathan.druart, nick
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20031: CGI param in list context warn in guided_reports.pl

Description Marcel de Rooy 2018-01-18 14:40:04 UTC

    
Comment 1 Marcel de Rooy 2018-01-18 14:44:43 UTC
Created attachment 70692 [details] [review]
Bug 20031: CGI param in list context warn in guided_reports.pl

Resolve warn:
CGI::param called in list context from package CGI::Compile::ROOT::usr_share_koha_shadowclone_reports_guided_reports_2epl line 794, this can lead to vulnerabilities. [NOTE: line number from older Koha version.]

Test plan:
Looking at this change should convince you already. Another look at this
routine in C4/Output.pm would be bonus.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Jonathan Druart 2018-02-02 13:44:04 UTC
I was going to submit it
Comment 3 Jonathan Druart 2018-02-02 15:10:45 UTC
Pushed to master for 18.05
Comment 4 Nick Clemens 2018-02-16 02:29:20 UTC
Awesome work all, pushed to stable for 17.11.03