Summary: | Invalid markup in staff client's header.inc | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19851 | ||
Bug Blocks: | |||
Attachments: |
Bug 20051: Invalid markup in staff client's header.inc
Bug 20051: Invalid markup in staff client's header.inc Bug 20051: Invalid markup in staff client's header.inc Bug 20051: Invalid markup in staff client's header.inc |
Description
Owen Leonard
2018-01-19 19:38:05 UTC
Created attachment 70777 [details] [review] Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Created attachment 70783 [details] [review] Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Created attachment 70973 [details] [review] Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> git grep tells me we are going to affect that line: koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: $('ul[aria-labelledby="drop3"]').html('<li><a class="toplinks">You cannot change your branch or logout while using offline circulation</a></li>'); Created attachment 71086 [details] [review] Bug 20051: Invalid markup in staff client's header.inc This patch corrects markup errors in header.inc which introduced by Bug 19851. For id attributes on <span>s have been replaced with classes, eliminating an HTML validator error about duplicate ids. Minor unrelated change: Updated an element's id with a more descriptive name. Test plan the same as Bug 19851's: - Log in to the staff client and confirm that the appearance of the menu bar at the top of the screen looks correct at various browser widths. - Confirm that the logged-in user menu label and help link expand and collapse according to browser width. Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Fix for QA: Corrected ID reference in circ/offline.tt Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |