| Summary: | Add Reports object class | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15449 | ||
| Bug Blocks: | 20495 | ||
| Attachments: |
Bug 20052 - Add Koha Reports object class
Bug 20052 - Add Koha Reports object class Bug 20052 - Add Koha Reports object class Bug 20052: (follow-up) Fix QA tool complaints and bad copy Bug 20052: Add Koha Reports object class Bug 20052: (follow-up) Fix QA tool complaints and bad copy |
||
|
Description
Nick Clemens (kidclamp)
2018-01-20 20:40:41 UTC
Created attachment 70784 [details] [review] Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Created attachment 70845 [details] [review] Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 72386 [details] [review] Bug 20052 - Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Comment on attachment 72386 [details] [review] Bug 20052 - Add Koha Reports object class Review of attachment 72386 [details] [review]: ----------------------------------------------------------------- Hi Nick, Is this base work for a new feature? there are some issues with POD here: 1) FAIL Koha/Report.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid FAIL Koha/Reports.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' OK spelling OK valid ::: t/db_dependent/Koha/Reports.t @@ +1,3 @@ > +#!/usr/bin/perl > + > +# Copyright 2015 Koha Development team 2) Should we lose this line here on a new file? Created attachment 73422 [details] [review] Bug 20052: (follow-up) Fix QA tool complaints and bad copy (In reply to Katrin Fischer from comment #4) > Is this base work for a new feature? Yes, was looking towards refactoring C4/Reports/Guided.pm to eliminate some function (get_saved_report, get_saved_reports, etc.) Hey Nick, please remember, it's Bug XXXX: in the commit message ;) Created attachment 73455 [details] [review] Bug 20052: Add Koha Reports object class To test: prove -v t/db_dependent/Koha/Reports.t Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 73456 [details] [review] Bug 20052: (follow-up) Fix QA tool complaints and bad copy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Enhancement, not backporting to 17.11.x |