Description
Indranil Das Gupta
2018-01-21 18:09:39 UTC
Created attachment 70787 [details] [review] Bug 20054 - Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Created attachment 70798 [details] [review] Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 70979 [details] [review] Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Maksim Sen <maksim@inlibro.com> Created attachment 71027 [details] [review] Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: maksim <maksim@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> What about the staff interface? I have submitted Bug 20102 - Remove attribute "text/css" for <style> element used in staff client templates. Hi Indranil, the patch does not longer apply, can you rebase? It sounds like it would be better to regenerate it, I guess you wrote a small script? (In reply to Jonathan Druart from comment #7) > Hi Indranil, the patch does not longer apply, can you rebase? > It sounds like it would be better to regenerate it, I guess you wrote a > small script? This comment was for bug 20053. Created attachment 71499 [details] [review] Bug 20054: Remove attribute "text/css" for <style> element in OPAC Conformance rules for HTML5 is generating warnings for <style> element with type="text/css" attribute when the OPAC page is checked with W3C Validator. Test plan ========= 1/ Click the "Tag cloud" link on the OPAC. Paste the URL to your OPAC page (if it is hosted) to W3C Validator and watch the warning about type attribute "text/css". 2/ Apply patch and re-submit the page to the Validator. The warning will be gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: maksim <maksim@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |