|
Description
Stefan Berndtsson
2018-01-22 11:40:33 UTC
Created attachment 70790 [details] [review] Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Created attachment 70925 [details] [review] Bug 20057 - Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Created attachment 70926 [details] Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Created attachment 70927 [details] [review] Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Looking at the earlier comments, shouldn't this bug have the status Signed off? This needs a rebase - changing status to reflect. Created attachment 105075 [details] [review] Bug 20057 - Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Created attachment 105076 [details] [review] Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Hi David, can you explain PatronSelfRegistrationVerifyByEmail in your test plan? This should only be valid for registrations, not for changes. So I think in your plan it should probably work with either setting of the pref? Created attachment 105142 [details] [review] Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. @Katrin Fischer. Sorry, just rebased, had some real nasty issues with git bz/am and the fastest way to get around them was to reconstruct the commits manually and forgot to change the author of the last commit. So I'm not the author of that one. (Have now corrected the commit author). So regarding your question I'm not at all familiar with this patch and cannot give a direct answer. I can perhaps get back to it later, but right now don't have time to figure this out. Created attachment 105303 [details] [review] Bug 20057: System preference for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via OPAC interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 105304 [details] [review] Bug 20057: (follow-up) Add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 105305 [details] [review] Bug 20057: Fix capitalization and rephrase system preference as a sentence This makes changes to strings involved in this feature: - Rephrases the system preference description into a sentence - Rephrases message shown in OPAC on submitting (library has not actively approved, so just say that the record has been modified) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I've fixed up the patches to apply to standards (capitalization and commit messages). I can't make out why PatronSelfRegistrationVerifyByEmail should be relevant here, so I have removed it from the commit messages. I've also tested the workflow for self registrations. Please QA team, can you double check this? We use opac-memberentry.pl for a few too many things. (In reply to Katrin Fischer from comment #18) > Please QA team, can you double check this? We use opac-memberentry.pl for a > few too many things. That seems correct to me. Maybe we should rename the pref to match "SelfModification", like "AutoApprovePatronSelfModification"? Idea of improvement: we could make it a list of patron's categories instead of a global switch. Created attachment 109288 [details] [review] Bug 20057: System preference for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via OPAC interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 109289 [details] [review] Bug 20057: (follow-up) Add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 109290 [details] [review] Bug 20057: Fix capitalization and rephrase system preference as a sentence This makes changes to strings involved in this feature: - Rephrases the system preference description into a sentence - Rephrases message shown in OPAC on submitting (library has not actively approved, so just say that the record has been modified) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 20.11, thanks to everybody involved! enhancement will not be backported to 20.05.x |