| Summary: | Uninitialized warn from Koha::Template::Plugin::Branches | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | mtompset, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches
Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches |
||
|
Description
Marcel de Rooy
2018-01-22 12:03:50 UTC
Created attachment 70793 [details] [review] Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> To convince you. This is how userenv looks:
$VAR1 = {
'branchprinter' => undef,
'emailaddress' => undef,
'branchname' => undef,
'surname' => undef,
'branch' => undef,
'persona' => undef,
'firstname' => undef,
'cardnumber' => undef,
'id' => '',
'barshelves' => undef,
'pubshelves' => undef,
'shibboleth' => undef,
'totshelves' => undef,
'flags' => undef,
'number' => undef
};
Created attachment 71078 [details] [review] Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> I triggered this with just "localhost:8081" in the address bar in chrome. A url with mainpage did not trigger it for me. (In reply to M. Tompsett from comment #4) > I triggered this with just "localhost:8081" in the address bar in chrome. A > url with mainpage did not trigger it for me. Thx for signing off. Mainpage triggered it while being logged out iirc. Created attachment 71169 [details] [review] Bug 20060: Resolve uninitialized warn from Koha::Template::Plugin::Branches The warn comes from undefined C4::Context->userenv->{branch}. Can be triggered by calling mainpage.pl when being logged out in staff. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> localhost:8081/cgi-bin/koha/mainpage.pl did it for me. Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |