| Summary: | koha-common is not pulling libsearch-elasticsearch-perl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Packaging | Assignee: | Mirko Tietgen <mirko> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, mirko, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 19542 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl
Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control |
||
|
Description
Tomás Cohen Arazi (tcohen)
2018-01-22 12:25:09 UTC
I am not sure if this should be a hard dependency - as long as Koha is supposed to work without Elasticsearch - for an enhancement that just displays Elasticsearch infos when Elasticsearch is activated (as far as I understand) Could we tie loading the module to a condition like the SearchEngine syspref setting instead or does that not make sense? (In reply to Mirko Tietgen from comment #1) > I am not sure if this should be a hard dependency > - as long as Koha is supposed to work without Elasticsearch > - for an enhancement that just displays Elasticsearch infos when > Elasticsearch is activated (as far as I understand) > > Could we tie loading the module to a condition like the SearchEngine syspref > setting instead or does that not make sense? I've always been strongly against having 'Break Koha' option switches. I think the SearchEngine syspref is a 'Break Koha' option switch as long as Elasticsearch Perl dependencies are not shipped/pulled. I agree we can workaround the about.pl problem. But we still have break switches. There has been talk about getting ElasticSearch production ready for 18.05 - I think if that is the goal, we should ship with the dependency. Is it hard to pack or are there other reasons against it? Size? My understanding was (In reply to Katrin Fischer from comment #3) > There has been talk about getting ElasticSearch production ready for 18.05 - > I think if that is the goal, we should ship with the dependency. Is it hard > to pack or are there other reasons against it? Size? We already have it. It's just not needed without actually using ES. So far we have not added ES dependencies as mandatory to allow Koha to be run Zebra-only. Maybe it's not really an important question. AFAIK libsearch-elasticsearch-perl does not depend on actually installing Elasticsearch, so Zebra users don't have extra work. I agree with Tomas that having setting options that kill Koha is not a good thing. I'll reset to needs signoff, feel free to go back to more discussion if needed. My bad, there is no code to sign off :D Created attachment 72116 [details] [review] Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl Adds Search::Elasticsearch to Perldependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 72117 [details] [review] Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control update debian/control. this file is auto generated. no testing required. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Sorry Tomas, I stole your bug. I can offer you a signoff though. Created attachment 72118 [details] [review] Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl Adds Search::Elasticsearch to Perldependencies.pm Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 72119 [details] [review] Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl / d/control update debian/control. this file is auto generated. no testing required. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> (In reply to Mirko Tietgen from comment #8) > Sorry Tomas, I stole your bug. I can offer you a signoff though. Thanks :-D Pushed to master for 18.05, thanks to everybody involved! Is this suitable for backporting Mirko? or is anything else needed? (In reply to Nick Clemens from comment #13) > Is this suitable for backporting Mirko? or is anything else needed? Nick: You skipped bug 19542, so you can skip this one too. I think it should go to resolved fixed. |