Bug 20091

Summary: FailedLoginAttempts is not part of NorwegianPatronDatabase pref group
Product: Koha Reporter: Nick Clemens <nick>
Component: System AdministrationAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, jonathan.druart, julian.maurice
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18314    
Bug Blocks:    
Attachments: Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading

Description Nick Clemens 2018-01-26 12:45:17 UTC

    
Comment 1 Nick Clemens 2018-01-26 12:47:12 UTC
Created attachment 70952 [details] [review]
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading

To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'
Comment 2 Mark Tompsett 2018-01-26 13:44:15 UTC
Created attachment 70954 [details] [review]
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading

To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Maksim Sen 2018-01-26 21:20:23 UTC
Created attachment 70984 [details] [review]
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading

To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Maksim Sen <maksim@inlibro.com>
Comment 4 Julian Maurice 2018-01-29 16:42:35 UTC
Created attachment 71028 [details] [review]
Bug 20091: Moved FailedLoginAttempts out of Norwegian Patron Database heading

To test:
1 - View systempreferences patron tab
2 - Note FailedLoginAttempts is uner 'Norwegian Patron Database'
3 - apply patch
4 - Now it is under 'General'

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Maksim Sen <maksim@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Jonathan Druart 2018-01-30 17:26:46 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 6 Nick Clemens 2018-02-12 20:56:43 UTC
Awesome work all!

This patch has been pushed to 17.11.x and will be in 17.11.03