Summary: | Update minimum version of Perl to 5.20 because of caller() | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | Installation and upgrade (web-based installer) | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, jonathan.druart, martin.renvoize, roch.damour |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12932 | ||
Bug Blocks: | 20594 | ||
Attachments: |
Bug 20104: Update minimum version of Perl to 5.20
Bug 20104: Update minimum version of Perl to 5.20 Bug 20104: Update minimum version of Perl to 5.20 |
Description
Mark Tompsett
2018-01-30 19:46:41 UTC
Created attachment 71074 [details] [review] Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. Created attachment 73806 [details] [review] Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 73829 [details] [review] Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Will also require a change to the release notes (scripts) I think as the minimal requirements are part of the text. Pushed to master for 18.05, thanks to everybody involved! (In reply to M. Tompsett from comment #0) > The C4::Log::cronlogaction uses caller, which did not exist prior to 5.20. That is false. You can find "caller" in RHEL 6.9 which is still using Perl 5.10. And I just used it in Perl 5.18. I just bumped into this change preventing me from working on Koha master on OpenSUSE 42.3, which was released 2017-07-26. It uses Perl 5.18.2, which has worked fine with Koha. Requiring 5.20 seems like an awfully big decision, which seems to have had no discussion in the community. I'm going to send out a listserv email to hear what others have to say. As Mason pointed out to me on IRC, the perldoc site search results seems broken for older versions of Perl. As you can see, caller has been around a very long time: https://perldoc.perl.org/5.8.8/functions/caller.html Comment on attachment 73829 [details] [review] Bug 20104: Update minimum version of Perl to 5.20 Review of attachment 73829 [details] [review]: ----------------------------------------------------------------- ::: installer/install.pl @@ +93,4 @@ > $template->param( 'checkmodule' => 1 ) > ; # we start with the assumption that there are no problems and set this to 0 if there are > > + unless ( $] >= 5.020000 ) { # Bug 20104 Then change this back to 5.010000 -- clearly the perldoc site needs improvement. I was just trying to make sure the version of perl needed was accurately reflected. @@ +93,5 @@ > $template->param( 'checkmodule' => 1 ) > ; # we start with the assumption that there are no problems and set this to 0 if there are > > + unless ( $] >= 5.020000 ) { # Bug 20104 > + $template->param( problems => 1, perlversion => '5.20', checkmodule => 0 ); And this to 5.10 ::: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt @@ +70,4 @@ > <p>I encountered some problems.</p> > <ul> > [% IF ( perlversion ) %] > + <li>Your Perl version is out of date. Please upgrade to a newer version of Perl (at least version [% perlversion %]).</li> Because this refactor is worth keeping, I believe. (In reply to M. Tompsett from comment #9) > Because this refactor is worth keeping, I believe. I have put the reversion of Perl version in bug 20594. Thank you for correcting me, David. Reverted. |