Bug 20126

Summary: Saving a biblio does no longer update MARC field lengths
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Architecture, internals, and plumbingAssignee: Marcel de Rooy <m.de.rooy>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: dcook, fridolin.somers, jonathan.druart+koha, nick
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 10455    
Bug Blocks:    
Attachments: Bug 20126: Restore MARC field length calculation in ModBiblioMarc
Bug 20126: Add simple test for ModBiblioMarc
Bug 20126: Restore MARC field length calculation in ModBiblioMarc
Bug 20126: Add simple test for ModBiblioMarc

Description Marcel de Rooy 2018-02-02 10:27:50 UTC
See bug 10455.
Comment 1 Marcel de Rooy 2018-02-02 10:41:14 UTC
Created attachment 71140 [details] [review]
Bug 20126: Restore MARC field length calculation in ModBiblioMarc

Trivial fix. Problem raised by bug 10455.

Test plan:
[1] Create or edit biblio record.
[2] Save and check leader field lengths in MARC view.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2018-02-02 11:07:46 UTC
Created attachment 71145 [details] [review]
Bug 20126: Add simple test for ModBiblioMarc

Just to confirm that we see record length and base address in a record
that has been passed through ModBiblioMarc.

Test plan:
Run the test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Nick Clemens 2018-02-02 12:39:06 UTC
Created attachment 71146 [details] [review]
Bug 20126: Restore MARC field length calculation in ModBiblioMarc

Trivial fix. Problem raised by bug 10455.

Test plan:
[1] Create or edit biblio record.
[2] Save and check leader field lengths in MARC view.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Nick Clemens 2018-02-02 12:39:09 UTC
Created attachment 71147 [details] [review]
Bug 20126: Add simple test for ModBiblioMarc

Just to confirm that we see record length and base address in a record
that has been passed through ModBiblioMarc.

Test plan:
Run the test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Jonathan Druart 2018-02-02 15:21:09 UTC
Pushed to master for 18.05
Comment 6 Nick Clemens 2018-02-16 02:28:34 UTC
Awesome work all, pushed to stable for 17.11.03
Comment 7 Fridolin Somers 2018-02-19 13:00:23 UTC
Pushed to 17.05.x for v17.05.09
Comment 8 David Cook 2022-06-27 01:11:45 UTC
Why was this considered a problem?