| Summary: | Staff client header language menu doesn't show check mark for current language | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 20156 - Staff client header language menu doesn't show check mark for current language
Bug 20156 - Staff client header language menu doesn't show check mark for current language Bug 20156 - Staff client header language menu doesn't show check mark for current language |
||
|
Description
Owen Leonard
2018-02-07 17:37:39 UTC
Created attachment 71297 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Created attachment 71298 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Created attachment 71329 [details] [review] Bug 20156 - Staff client header language menu doesn't show check mark for current language This patch replaces Glyphicon markup with Font Awesome markup so that a check mark appears next to the currently-selected language in the staff client header's language menu. Also changed in this patch: Some classes have been removed because they are not used in staff client CSS. To test you must have multiple languages installed and enabled in the staff client. - Set the StaffLangSelectorMode system preference to "top" or "both top and footer" - Confirm that the currently-select language in the langauge menu has a check mark next to it. Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Awesome work all, pushed to stable for 17.11.03 |