| Summary: | Position of NoLoginInstructions text is inconsistent | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Margaret Hade <margaret> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Side By Side NoLoginInstructions Text Comparison
Bug 20163: Position of NoLoginInstructions text is inconsistent Bug 20163: Position of NoLoginInstructions text is inconsistent Bug 20163: Position of NoLoginInstructions text is inconsistent |
||
Created attachment 71357 [details] [review] Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Created attachment 71426 [details] [review] Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 71532 [details] [review] Bug 20163: Position of NoLoginInstructions text is inconsistent This patch modifies the markup for two login forms, making the markup more consistent between them. The order of NoLoginInstructions, "Forgot your password?" and "Don't have an account?" should now be the same. This patch also updates some classes in each login form to allow for more consistent custom styling. A couple of capitalization corrections are included. To test, enable the PatronSelfRegistration and OpacResetPassword preferences. Put some text in the NoLoginInstructions preference. View the login form as associated links on the OPAC main page. Compare to the login form which appears in a modal window when you click the login link at the top of the page. The two areas should look consistent. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Includes string changes! Pushed to master for 18.05, thanks to everybody involved! |
Created attachment 71356 [details] Side By Side NoLoginInstructions Text Comparison The position of NoLoginInstructions text is inconsistent between the "log into your account" popup and the "log into your account" main login form. In this case directional language is used in the NoLoginInstructions to have patrons look "above" for the Register here link. However in the popup the position of the two texts are flipped, so that the Register here link appears bellow the NoLoginInstructions. See Screenshot, "Side By Side NoLoginInstructions Text Comparison" for this illustration. To replicate: 1) Enable PatronSelfRegistration system preference. 2) Enable the OpacResetPassword system preference. 3) Input directional language, ie. "look [above or bellow] for the Register here link, into the NoLoginInstructions syspref. 4) Open OPAC and look at the "log into your account" popup and the "log into your account" main login form. Your instructions to look above or bellow will be wrong in one one of these login windows. Can the order in which the editable (ie. NoLoginInstructions) and non-editable (ie. Register here and Forgot Password) text that appears in the "log into your account" main login form and popup be made consistent?