Bug 20174

Summary: Remove xml_sax.pl target from Makefile.pl
Product: Koha Reporter: David Cook <dcook>
Component: Installation and upgrade (command-line installer)Assignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: trivial    
Priority: P5 - low CC: josef.moravec, katrin.fischer, martin.renvoize, mirko, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20174: Remoe xml_sax.pl target from Makefile.pl
Bug 20174: Remoe xml_sax.pl target from Makefile.pl
Bug 20174: Remove xml_sax.pl target from Makefile.pl

Description David Cook 2018-02-12 02:59:20 UTC
A line was added to Makefile.PL with Bug #5033 but it doesn't seem like it's used anymore?
Comment 1 Katrin Fischer 2019-02-10 00:49:09 UTC
Can confirm the line is still there:

Makefile.PL:  './xml_sax.pl'                => 'PERL_MODULE_DIR',

I can't find a file in Koha with this name.
Comment 2 Katrin Fischer 2019-02-10 00:50:08 UTC
Created attachment 84942 [details] [review]
Bug 20174: Remoe xml_sax.pl target from Makefile.pl

There appears to be no xml_sax.pl in Koha, so the
reference should be removed.
Comment 3 Martin Renvoize 2019-02-12 13:59:05 UTC
Created attachment 85018 [details] [review]
Bug 20174: Remoe xml_sax.pl target from Makefile.pl

There appears to be no xml_sax.pl in Koha, so the
reference should be removed.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-02-12 13:59:49 UTC
This makes total sense to me, signing off.
Comment 5 Josef Moravec 2019-02-12 20:59:35 UTC
Created attachment 85026 [details] [review]
Bug 20174: Remove xml_sax.pl target from Makefile.pl

There appears to be no xml_sax.pl in Koha, so the
reference should be removed.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Nick Clemens 2019-02-15 18:49:08 UTC
Awesome work all!

Pushed to master for 19.05
Comment 7 Martin Renvoize 2019-02-25 15:26:33 UTC
Pushed to 18.11.x for 18.11.04