| Summary: | Remove xml_sax.pl target from Makefile.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | josef.moravec, martin.renvoize, mirko, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 20174: Remoe xml_sax.pl target from Makefile.pl
Bug 20174: Remoe xml_sax.pl target from Makefile.pl Bug 20174: Remove xml_sax.pl target from Makefile.pl |
||
|
Description
David Cook
2018-02-12 02:59:20 UTC
Can confirm the line is still there: Makefile.PL: './xml_sax.pl' => 'PERL_MODULE_DIR', I can't find a file in Koha with this name. Created attachment 84942 [details] [review] Bug 20174: Remoe xml_sax.pl target from Makefile.pl There appears to be no xml_sax.pl in Koha, so the reference should be removed. Created attachment 85018 [details] [review] Bug 20174: Remoe xml_sax.pl target from Makefile.pl There appears to be no xml_sax.pl in Koha, so the reference should be removed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This makes total sense to me, signing off. Created attachment 85026 [details] [review] Bug 20174: Remove xml_sax.pl target from Makefile.pl There appears to be no xml_sax.pl in Koha, so the reference should be removed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 |