Summary: | Remove GROUP BY in get_shelves_containing_record | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, roch.damour |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20144 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 17258, 20521 | ||
Attachments: |
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record
Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record |
Description
Julian Maurice
2018-02-12 13:53:00 UTC
Created attachment 71470 [details] [review] Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Is that right? Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> If there are multiple virtualshelfshares, get_shelves_containing_record can return the same virtualshelf multiple times. Created attachment 71626 [details] [review] Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Replaced with distinct. Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t Created attachment 73063 [details] [review] Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Replaced with distinct. Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 73861 [details] [review] Bug 20179: [sql_modes] Remove GROUP BY in get_shelves_containing_record Replaced with distinct. Fix for: 'koha_kohadev.me.shelfname' isn't in GROUP BY t/db_dependent/Virtualshelves.t Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master for 18.05, thanks to everybody involved! |