|
Description
Jonathan Druart
2018-02-14 17:20:57 UTC
Created attachment 71623 [details] [review] Bug 20199: Add tests for Koha::Acq::Order->store Created attachment 71624 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Created attachment 72163 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 72166 [details] [review] Bug 20199: Add tests for Koha::Acq::Order->store Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 72167 [details] [review] Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! I think this is not needed for 17.11, let me know if I am wrong |