| Summary: | Add IDs to buttons in patron-toolbar.inc | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Magnus Enger <magnus> |
| Component: | Patrons | Assignee: | Magnus Enger <magnus> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 20205 - Add IDs to buttons in patron-toolbar.inc
Bug 20205 - Add IDs to buttons in patron-toolbar.inc k Bug 20205: Add IDs to buttons in patron-toolbar.inc |
||
|
Description
Magnus Enger
2018-02-15 09:08:37 UTC
Created attachment 71641 [details] [review] Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Created attachment 71658 [details] [review] Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 71696 [details] [review] k Created attachment 71697 [details] [review] Bug 20205: Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |