Description
Christophe Croullebois
2018-02-23 15:16:57 UTC
Created attachment 72207 [details] [review] Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Upping severity. Created attachment 72208 [details] [review] Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Created attachment 72245 [details] [review] Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> <a href="https://[% BakerTaylorBookstoreURL |uri %] This is wrong. Created attachment 72280 [details] [review] Bug 20286: Fix filter for BakerTaylor* prefs Can anyone test these patches with BakerTaylor* prefs set correctly? We have a Baker and Taylor we can test with. (I am on this patch) (In reply to Jonathan Druart from comment #7) > Can anyone test these patches with BakerTaylor* prefs set correctly? Created attachment 72629 [details] [review] Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 72630 [details] [review] Bug 20286: Fix filter for BakerTaylor* prefs Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 72650 [details] [review] Bug 20286: Correctly escape URI characters in OPAC RSS template Bug 19568 use the TT filter url whereas it must have escaped the URI characters with the uri filter. Test plan: Subscribe to an OPAC search => Without this patch you will get an empty page => With this patch applied you will see result list. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Created attachment 72651 [details] [review] Bug 20286: Fix filter for BakerTaylor* prefs Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Pushed to master, will be in 18.05 Awesome work all, backported to stable for 17.11.05 Pushed to 17.05.x for v17.05.11 |