Bug 20321

Summary: C4:XISBN->get_biblionumber_from_isbn is not used
Product: Koha Reporter: Nick Clemens <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: minor    
Priority: P5 - low CC: josef.moravec, roch.damour
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20321 - Remove get_biblionumber_from_isbn
Bug 20321 - Remove get_biblionumber_from_isbn
Bug 20321 - Remove get_biblionumber_from_isbn

Description Nick Clemens 2018-03-01 16:33:21 UTC
Let remove it
Comment 1 Nick Clemens 2018-03-01 16:35:02 UTC
Created attachment 72340 [details] [review]
Bug 20321 - Remove get_biblionumber_from_isbn

To test:
1 - grep get_biblionumber_from_isbn
2 - verify all occurences are not actual calls (except for test)
3 - Apply patch
4 - grep get_biblionumber_from_isbn
5 - Verify it is removed
Comment 2 Roch D'Amour 2018-03-02 20:46:43 UTC
Created attachment 72385 [details] [review]
Bug 20321 - Remove get_biblionumber_from_isbn

To test:
1 - grep get_biblionumber_from_isbn
2 - verify all occurences are not actual calls (except for test)
3 - Apply patch
4 - grep get_biblionumber_from_isbn
5 - Verify it is removed

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>
Comment 3 Josef Moravec 2018-03-05 11:39:38 UTC
Created attachment 72433 [details] [review]
Bug 20321 - Remove get_biblionumber_from_isbn

To test:
1 - grep get_biblionumber_from_isbn
2 - verify all occurences are not actual calls (except for test)
3 - Apply patch
4 - grep get_biblionumber_from_isbn
5 - Verify it is removed

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Jonathan Druart 2018-03-19 18:31:28 UTC
Pushed to master for 18.05, thanks to everybody involved!