| Summary: | Batch patron modification tool broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Architecture, internals, and plumbing | Assignee: | Josef Moravec <josef.moravec> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | cslone, nick, roch.damour |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18403 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20323: Fix batch patron modification tool
Bug 20323: Fix batch patron modification tool Bug 20323: Fix batch patron modification tool |
||
Created attachment 72347 [details] [review] Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Created attachment 72384 [details] [review] Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 72541 [details] [review] Bug 20323: Fix batch patron modification tool Test plan: 1) Go to Tools -> Batch patrons modification 2) Select some patrons and try to change any field --> without patch - it exploads with log: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl --> with patch - the modification is properly made Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to all for your hard work. Depends on 18403 which is not in stable, not backporting for 17.11 |
From tools/modborrowers.pl 341 if ( $patron ) { 342 $patron = $patron->unblessed; 343 $patron->{category_description} = $patron->category->description; This was added by bug 18403 and leads (obviosly) to error: Can't call method "category" on unblessed reference at /home/vagrant/kohaclone/tools/modborrowers.pl