Summary: | Add missing classes to search results elements | ||
---|---|---|---|
Product: | Koha | Reporter: | paxed <pasi.kallinen> |
Component: | Staff interface | Assignee: | paxed <pasi.kallinen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | gmcharlt, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20347: Add missing classes to search results elements
Bug 20347: Add missing classes to search results elements Bug 20347: Add missing classes to search results elements |
Description
paxed
2018-03-07 07:39:39 UTC
Created attachment 72497 [details] [review] Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Patch tested with a sandbox, by Sebastian Hierl <s.hierl@aarome.org> Created attachment 72826 [details] [review] Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Sebastian Hierl <s.hierl@aarome.org> Created attachment 73070 [details] [review] Bug 20347: Add missing classes to search results elements The MARC21 XSLT doesn't add html classes to distinguish between certain elements, and there's no way to rely on the element positioning, making it impossible to style the elements with CSS. Add the missing classes to distinguish the elements. Test plan: 1) Apply patch 2) Search for any biblios 3) Check the search result page table HTML to see that the "Publisher", "Edition", "Source", "Other title", and "Online access" are wrapped in a span with class of results_summary and one of "publisher", "edition", "source", "other_title", and "online_access" 4) Check that the search results of the elements above looks correct when compared to the other elements Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Sebastian Hierl <s.hierl@aarome.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |