| Summary: | Privacy management shows misleading "No reading history to delete" | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | OPAC | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | david.bourgault, josef.moravec, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 16966 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20363: (bug 16966 follow-up) better messages handling
Bug 20363: (bug 16966 follow-up) better messages handling Bug 20363: (bug 16966 follow-up) better messages handling Bug 20363: (bug 16966 follow-up) better messages handling |
||
|
Description
paxed
2018-03-09 07:57:58 UTC
(In reply to paxed from comment #0) > Error caused by commit 286be46e8a8 Bug 16966 Created attachment 73208 [details] [review] Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. *** Bug 20429 has been marked as a duplicate of this bug. *** Comment on attachment 73208 [details] [review] Bug 20363: (bug 16966 follow-up) better messages handling Review of attachment 73208 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt @@ +27,4 @@ > > [% IF deleted %] > <div class="alert alert-success">Your reading history has been deleted.</div> > + [% ELSIF err_history_not_deleted %] err_ does not match perl script's template_param. Created attachment 73432 [details] [review] Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. Created attachment 74663 [details] [review] Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Created attachment 74670 [details] [review] Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |