Summary: | Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it | ||
---|---|---|---|
Product: | Koha | Reporter: | Saketh Katari <saketh9977> |
Component: | Architecture, internals, and plumbing | Assignee: | David Roberts <david.roberts> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | 1joynelson, david.roberts, fridolin.somers, jonathan.druart, lucas, nick |
Version: | unspecified | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.05.00, 19.11.06
|
|
Circulation function: | |||
Attachments: |
Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it
Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it |
Description
Saketh Katari
2018-03-10 07:40:09 UTC
Created attachment 102789 [details] [review] Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it This patch changes the wording of the comment To test: 1) Check the wording of Line 67 of Koha/AuthUtils.pm 2) Apply the patch 3) Check that the wording has changed from "Encrypt it" to "Hash it" Created attachment 102858 [details] [review] Bug 20370: Misleading comment for bcrypt - #encrypt it; Instead it should be #hash it This patch changes the wording of the comment To test: 1) Check the wording of Line 67 of Koha/AuthUtils.pm 2) Apply the patch 3) Check that the wording has changed from "Encrypt it" to "Hash it" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Comment change - moving to PQA directly. Nice work everyone! Pushed to master for 20.05 backported to 19.11.x for 19.11.06 backported to 19.05.x for 19.05.11 |