Bug 20382

Summary: Missing space between patron and cardnumber on check out screen
Product: Koha Reporter: Claire Gravely <claire_gravely>
Component: TemplatesAssignee: Claire Gravely <claire_gravely>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: katrin.fischer, sandboxes
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20382: Missing space between patron and cardnumber on check out screen
Bug 20382: Missing space between patron and cardnumber on check out screen
Bug 20382: Missing space between patron and cardnumber on check out screen

Description Claire Gravely 2018-03-13 08:50:33 UTC
There should be a space between patron name and cardnumber on the check out screen
Comment 1 Claire Gravely 2018-03-13 08:56:50 UTC
Created attachment 72736 [details] [review]
Bug 20382: Missing space between patron and cardnumber on check out screen

There should be a space between patron name and cardnumber on the check
out screen.

This patch adds a space between patron and cardnumber.

To test:
 1 type a patron name into the check out search or go to the check out
 tab from a patron record
 2 Confirm there is no space between patron name and cardnumber on the
 check out page
 3 apply patch
 4 confirm there is now a space
 5 sign off :)
Comment 2 Biblibre Sandboxes 2018-03-14 10:24:11 UTC
Patch tested with a sandbox, by Sebastian Hierl <s.hierl@aarome.org>
Comment 3 Biblibre Sandboxes 2018-03-14 10:24:32 UTC
Created attachment 72837 [details] [review]
Bug 20382: Missing space between patron and cardnumber on check out screen

There should be a space between patron name and cardnumber on the check
out screen.

This patch adds a space between patron and cardnumber.

To test:
 1 type a patron name into the check out search or go to the check out
 tab from a patron record
 2 Confirm there is no space between patron name and cardnumber on the
 check out page
 3 apply patch
 4 confirm there is now a space
 5 sign off :)

Signed-off-by: Sebastian Hierl <s.hierl@aarome.org>
Comment 4 Katrin Fischer 2018-03-18 07:47:46 UTC
Created attachment 73073 [details] [review]
Bug 20382: Missing space between patron and cardnumber on check out screen

There should be a space between patron name and cardnumber on the check
out screen.

This patch adds a space between patron and cardnumber.

To test:
 1 type a patron name into the check out search or go to the check out
 tab from a patron record
 2 Confirm there is no space between patron name and cardnumber on the
 check out page
 3 apply patch
 4 confirm there is now a space
 5 sign off :)

Signed-off-by: Sebastian Hierl <s.hierl@aarome.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-03-19 18:32:00 UTC
Pushed to master for 18.05, thanks to everybody involved!