And also these templates are using it too: acqui/parcel.tt admin/smart-rules.tt reserve/request.tt Created attachment 72903 [details] [review] Bug 20395: Change paycollect to use Price formatter Confirmed Josef's comment with: git grep "format(['\"]%.2f['\"])" | grep [.]tt: git show 3910d5e8b I believe the best course of action for the currency line is to cut it. Created attachment 72976 [details] [review] Bug 20395: Followup to change format to use price filter See comment #1. Created attachment 73057 [details] [review] Bug 20395: Change paycollect to use Price formatter Test plan: 1) Apply patch 2) Go to Home -> Patrons -> Patron details (for any patron) 3) Create manual invoice for the patron 4) Pay fines -> Pay -button 5) Check that the currency values look correct 6) Pay fines -> Pay amount -button 7) Check that the currency values look correct 8) Pay fines -> Pay selected -button 9) Check that the currency values look correct 10) Change the CurrencyFormat setting 11) Repeat 2-9 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Created attachment 73058 [details] [review] Bug 20395: Followup to change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Hi Josef and others - I think fixing one file here is ok and easier to test. Let's move the others to separate bugs? ... Hm, missed the patch was already done. We should change the title in that case. The change on smart rules is incomplete, the fine amount still doesn't use the formatter, so we are getting a mixed display. can you please fix? Everything else appears to work nicely. (In reply to Katrin Fischer from comment #9) > The change on smart rules is incomplete, the fine amount still doesn't use > the formatter, so we are getting a mixed display. can you please fix? Anything that was formatted has been fixed already. Are you finding a different bug? It might look a little different in the code, but I think still worth fixing as with this patches we have a formatted value appearing right next to an unformatted value. Created attachment 136484 [details] [review] Bug 20395: Change paycollect to use Price formatter Test plan: 1) Apply patch 2) Go to Home -> Patrons -> Patron details (for any patron) 3) Create manual invoice for the patron 4) Pay fines -> Pay -button 5) Check that the currency values look correct 6) Pay fines -> Pay amount -button 7) Check that the currency values look correct 8) Pay fines -> Pay selected -button 9) Check that the currency values look correct 10) Change the CurrencyFormat setting 11) Repeat 2-9 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 136485 [details] [review] Bug 20395: Followup to change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Wow, can't believe this is still the case.. all sorted now and rebased. Passing QA Created attachment 136503 [details] [review] Bug 20395: (follow-up) Change format to use price filter See comment #1. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.04 backported to 21.11.x for 21.11.11 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. |
paycollect.tt still uses format('%.2f') instead of $Price