| Summary: | Remove "did you mean" for the staff interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Gaetan Boisson <gaetan.boisson> |
| Component: | System Administration | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | 1joynelson, eb, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
20.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 20396 | ||
| Attachments: |
Bug 20399: Remove "did you mean" for the staff interface
Bug 20399: Remove "did you mean" for the staff interface Bug 20399: Remove "did you mean" for the staff interface Bug 20399: Remove "did you mean" for the staff interface Bug 20399: Remove "did you mean" for the staff interface Bug 20399: (QA follow-up) Remove mention of INTRAdidyoumean from text and delete commented code |
||
|
Description
Gaetan Boisson
2018-03-14 13:49:28 UTC
Agreed Created attachment 101208 [details] [review] Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block Created attachment 101336 [details] [review] Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. I think there is a problem here with this minimalistic approach: - Go to the did you mean admin page - Make changes to sequence and check/uncheck something - Save - Check system preference / local use / INTRAdidyoumean, it will contain only ] - Access the did you mean page again - BOOM malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171 I had a follow-up ready to remove the note form the intro text as well - it appears unnecessary. (In reply to Katrin Fischer from comment #4) > I think there is a problem here with this minimalistic approach: > > - Go to the did you mean admin page > - Make changes to sequence and check/uncheck something > - Save > - Check system preference / local use / INTRAdidyoumean, it will contain > only ] > - Access the did you mean page again - BOOM > > malformed JSON string, neither tag, array, object, number, string or atom, > at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171 > > I had a follow-up ready to remove the note form the intro text as well - it > appears unnecessary. Do we remove INTRAdidyoumean syspref and related code ? (In reply to Fridolin SOMERS from comment #5) > (In reply to Katrin Fischer from comment #4) > > I think there is a problem here with this minimalistic approach: > > > > - Go to the did you mean admin page > > - Make changes to sequence and check/uncheck something > > - Save > > - Check system preference / local use / INTRAdidyoumean, it will contain > > only ] > > - Access the did you mean page again - BOOM > > > > malformed JSON string, neither tag, array, object, number, string or atom, > > at character offset 0 (before "]") at /usr/share/perl5/JSON.pm line 171 > > > > I had a follow-up ready to remove the note form the intro text as well - it > > appears unnecessary. > > Do we remove INTRAdidyoumean syspref and related code ? I guess we could - it's not been implemented in years and I suppose you can still easily add it back if you intend to develop it? (In reply to Katrin Fischer from comment #6) > (In reply to Fridolin SOMERS from comment #5) > > > > Do we remove INTRAdidyoumean syspref and related code ? > > I guess we could - it's not been implemented in years and I suppose you can > still easily add it back if you intend to develop it? Indeed, by looking at code for OPAC I'd say Created attachment 101562 [details] [review] Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved Created attachment 101662 [details] [review] Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Save works, syspref removed. Created attachment 101768 [details] [review] Bug 20399: Remove "did you mean" for the staff interface The amdin page for the "did you mean" feature has two block for setting it up in the staff interface, and a note saying this isn't implemented on the staff interface yet. We remove the part about the staff interface until it actually is implemented. Test plan : 1) Apply patch 2) Go to Administration > Did you mean? 3) See there is only the OPAC block 4) Change some checkboxes 5) Save configuration 6) Check that configuration is saved Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Save works, syspref removed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 101769 [details] [review] Bug 20399: (QA follow-up) Remove mention of INTRAdidyoumean from text and delete commented code Removes some last "remains" of INTRAdidyoumean. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice work everyone! Pushed to master for 20.05 enhancement not backported to 19.11.x |