Summary: | Remove StaffDetailItemSelection system preference and make the feature always on | ||
---|---|---|---|
Product: | Koha | Reporter: | Gaetan Boisson <gaetan.boisson> |
Component: | Staff interface | Assignee: | Sam Lau <samalau> |
Status: | Needs documenting --- | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | flyingendpaper, gmcharlt, jonathan.druart, lisette, lucas, martin.renvoize, oleonard, samalau |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Removes the system preference StaffDetailItemSelection which is no longer needed. The item selection column in the holdings table is now configurable via Table settings configuration.
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Bug Depends on: | 37309 | ||
Bug Blocks: | 20396 | ||
Attachments: |
Bug 20411: Remove StaffDetailItemSelection system preference
Bug 20411: Remove StaffDetailItemSelection system preference Screenshot from sandbox signoff attempt Bug 20411: Remove StaffDetailItemSelection system preference Bug 20411: Remove StaffDetailItemSelection system preference Bug 20411: Remove StaffDetailItemSelection system preference Bug 20411: Output only if pref has been deleted |
Description
Gaetan Boisson
2018-03-14 16:38:51 UTC
I'd not be opposed to removing the preference - any opinions on this one? It's super useful for Modifying Selected Items or Deleting Selected Items--I think there should just always be check boxes appearing next to the items. Maybe someone has an argument against having the check boxes next to the items? But IMO, they should just always be there. --h2, "A Real Cataloger":) Created attachment 168755 [details] [review] Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Created attachment 168761 [details] [review] Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Created attachment 168831 [details]
Screenshot from sandbox signoff attempt
I tried signing off using a sandbox, and it went well through verifying that the syspref was no longer in the system (it wasn't!). I couldn't verify that there were checkboxes still appearing next to item records because there were no longer any item records showing up in "Normal" displays of bib records--see attached scrrenshot.
Uncaught SyntaxError: expected expression, got '<<' Uncaught ReferenceError: build_items_table is not defined I think the patch does not apply and you got a merge conflict marker Coolness--thank you!!! (I'm helping!! I think! :) ) Created attachment 168835 [details] [review] Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> (In reply to Jonathan Druart from comment #6) > I think the patch does not apply and you got a merge conflict marker Should be fixed now Created attachment 168859 [details] [review] Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> It does not correctly work, there is a regression. The action links ("Delete" and "Modify") are always displayed, they should be only if at least one item is selected. Created attachment 170310 [details] [review] Bug 20411: Remove StaffDetailItemSelection system preference This patch removes the 'StaffDetailItemSelection' along with any usages of it. Now, the checkboxes on an item details page are always there. To test: 1) Apply patch, restart_all, updatedatabase 2) In sys prefs, search for 'StaffDetailItemSelection', nothing should show up. 3) Visit an items details page, make sure there are checkboxes next each item that allow you to perform modification/deletion. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 170311 [details] [review] Bug 20411: Output only if pref has been deleted Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (In reply to Jonathan Druart from comment #11) > It does not correctly work, there is a regression. The action links > ("Delete" and "Modify") are always displayed, they should be only if at > least one item is selected. This was caused by a couple of wrong conflict resolutions. For instance: - var tab = $("#" + tab_id + "_panel" ); + var tab = $("#" + tab_id); I have rebased the patch on top of bug 37309 which is also in the queue and modify this exact portion of code. Please add some notes! Pushed for 24.11! Well done everyone, thank you! |