Summary: | Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12904 | ||
Bug Blocks: | |||
Attachments: |
Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources
Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources k Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources |
Description
Owen Leonard
2018-03-15 10:16:02 UTC
Correction: Google Indic Transliteration is not affected, Twitter is. Created attachment 72927 [details] [review] Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. Created attachment 72964 [details] [review] Bug 20420 - Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 73243 [details] [review] k Created attachment 73244 [details] [review] Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources This patch removes [% KOHA_VERSION %] from the <script> tag for some third-party JavaScript sources. [% KOHA_VERSION %] should only be used for Koha's JS resources. To test, apply the patch and enable the SocialNetworks and NovelistSelect* preferences. In the OPAC, view the detail page for a bibliographic record. In the right-hand sidebar you should see social network icons for Google+ and Twitter. Clicking either of them should trigger a sharing popup window. If you have Novelist credentials and can enable the feature for the OPAC you should see Novelist content in the place specified in your preferences. If you don't have Novelist credentials, put some random text in the NovelistSelectProfile system preference. Looking at the detail page in the OPAC, view source. You should see a link to Novelist JS around line 1020 of the source. Clicking the link should show JavaScript. This confirms that the path is correct, thus the bug has been fixed. Note: The QA tool will complain that [% KOHA_VERSION %] is missing. This is a false positive. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Not needed for 17.11 |