Summary: | Can't import all titles from a stage file with default values | ||
---|---|---|---|
Product: | Koha | Reporter: | Koha Team University Lyon 3 <koha> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, koha, nick, sandboxes |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19453 | ||
Bug Blocks: | |||
Attachments: |
Bug 20426: Fix default fund value when adding orders from iso2709 file
Bug 20426: Fix default fund value when adding orders from iso2709 file Bug 20426: Fix default fund value when adding orders from iso2709 file |
Description
Koha Team University Lyon 3
2018-03-15 14:51:48 UTC
Hi Sonia, you need to select a fund in the "Default accounting details" tab or "Select to import" (one for each record to import). We tested this at the hackfest and selecting the fund on the default accounting details should work - otherwise it would have no function. Sonia also said that they used the feature a lot and it used to work like that. Ha, I think I found the problem. It has been caused by commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Created attachment 73530 [details] [review] Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund Patch tested with a sandbox, by Sonia Bouis <sonia.bouis@univ-lyon3.fr> Created attachment 73956 [details] [review] Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> I've followed the test plan and every was as expected : - I didn't define any fund on the first tab and on the third tab : I had a warning : "Some budgets are not defined in item records" - I defined only some funds in the first tab : I had a warning : "Some budgets are not defined in item records" - I defined a fund in the third tab : all my orders are imported in the right fund Thx Sonia! Created attachment 74064 [details] [review] Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! Pushed to stbale for 17.11.06 Awesome work all! Depends on Bug 19453 not in 17.05.x |