| Summary: | Overdue and pre-overdue cronjobs not skipping phone notices | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, danielle, eden.bacani, joonas.kylmala, lucas, tomascohen, wainuiwitikapark, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.07, 21.11.15
|
|
| Circulation function: | |||
| Attachments: |
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices
Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices |
||
|
Description
Kyle M Hall (khall)
2018-03-21 15:52:15 UTC
Created attachment 73141 [details] [review] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Another good alternative would be to have TT stop generating it's own notices, and instead have it use the notices generated by Koha. This would require a huge overhaul of the system though, but it's a good idea for later. This is still an issue, and it confusing to many library staff to see these notices in the message queue. It also makes support for the Talking Tech integration with Koha a bit more complicated to sort through. I volunteer as tribute to test/sign off on any patches. Hi, This doesn't seem to apply at the moment: CONFLICT (content): Merge conflict in misc/cronjobs/advance_notices.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices Sorry :( Liz Created attachment 86990 [details] [review] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Can you please make a more detailed test plan for me to test your patch Created attachment 115311 [details] [review] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Created attachment 140213 [details] [review] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Created attachment 141280 [details] [review] Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.07 release applied to 21.11 for 21.11.15 Backported to 21.05.x for 21.05.22 Not released in 21.05.22 (In reply to wainuiwitikapark from comment #14) > Not released in 21.05.22 Reverted from 21.05 branch |