| Summary: | Improper substitution of QUERY_KW in opac/opac-search.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Searching | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
We should probably do a case insensitive search: (my $query_kw=$query_desc)=~s/ (and|or) / /gi; |
If the system preference OPACNoResultsFound is enabled, all occurrences of the string {QUERY_KW} should be replaced with the query string if the query returns no results. In opac/opac-search.pl, the regular expression that we're using to remove the keywords 'and' and 'or' isn't properly grouped: (my $query_kw=$query_desc)=~s/ and|or / /g; will replace ' and' or 'or '; this should be (my $query_kw=$query_desc)=~s/ (and|or) / /g; To reproduce: Put "{QUERY_KW}" into OPACNoResultsFound Then do an opac search for soy andina or tractor trailer as long as neither of these is actually found, OPACNoResultsFound will show soy ina or tract trailer