Summary: | Passwordrecovery.t should mock Mail::Sendmail::sendmail | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Test Suite | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, mtompset, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18570 | ||
Bug Blocks: | |||
Attachments: |
Bug 20474: Explicitly call sendmail to make mocking work
Bug 20474: Mock sendmail instead of actually emailing Bug 20474: Explicitly call sendmail to make mocking work Bug 20474: Mock sendmail instead of actually emailing Bug 20474: Mimick Letters.t |
Description
Jonathan Druart
2018-03-26 14:54:10 UTC
Created attachment 73288 [details] [review] Bug 20474: Explicitly call sendmail to make mocking work Created attachment 73289 [details] [review] Bug 20474: Mock sendmail instead of actually emailing Copy mocking sendmail code from t/db_dependent/Letters.t into the Passwordrecovery.t test file. prove t/db_dependent/Passwordrecovery.t Created attachment 73322 [details] [review] Bug 20474: Explicitly call sendmail to make mocking work Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 73323 [details] [review] Bug 20474: Mock sendmail instead of actually emailing Copy mocking sendmail code from t/db_dependent/Letters.t into the Passwordrecovery.t test file. prove t/db_dependent/Passwordrecovery.t Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 73324 [details] [review] Bug 20474: Mimick Letters.t Please improve if needed the 2 occurrences on a separate bug reports. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Skipping QA to make Jenkins happy quickly. Pushed to master for 18.05, thanks to everybody involved! Awesome work all, backported to stable for 17.11.05 |