|
Description
Nick Clemens (kidclamp)
2018-03-27 12:49:47 UTC
Created attachment 73311 [details] [review] Bug 20479 - Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Created attachment 73312 [details] [review] Bug 20479 - Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> (In reply to Claire Gravely from comment #2) > Created attachment 73312 [details] [review] [review] > Bug 20479 - Don't kick superlibrarians out of the opac > > To test: > 1 - Try to log in to opac with a superlibrarian > 2 - Everythign goes wrong > 3 - Apply patch > 4 - Try to log in with superlibrarian > 5 - You can sign in > > Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> The patch is almost correct: it will fail for the DB user. BTW: I filed 20480 for the styling issue. Created attachment 73321 [details] [review] Bug 20479 (follow-up) Don't try to get flags for database user Login will still break in opac-user.pl, but that seems a bigger problem not from SCI module Created attachment 73326 [details] [review] Bug 20479: Use instead of fetching patron Created attachment 73327 [details] [review] Bug 20479: Don't kick superlibrarians out of the opac To test: 1 - Try to log in to opac with a superlibrarian 2 - Everythign goes wrong 3 - Apply patch 4 - Try to log in with superlibrarian 5 - You can sign in Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 73328 [details] [review] Bug 20479: (follow-up) Don't try to get flags for database user Login will still break in opac-user.pl, but that seems a bigger problem not from SCI module Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 73329 [details] [review] Bug 20479: Use instead of fetching patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 73331 [details] [review] Bug 20479: Use $flag instead of fetching patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> We could use $flags instead of haspermission, but it will make the code less readable. Maybe we need to create a new subroutine. Created attachment 73337 [details] [review] Bug 20479: Ease readability - do not enter the block if not logged in Pushed to master for 18.05, thanks to everybody involved! Depends on feature not in stable. |