Summary: | language_rfc4646_to_iso639 uses some Terminology instead of Bibliographic codes | ||
---|---|---|---|
Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
Component: | MARC Bibliographic data support | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, pe.havel |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20245 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 20482: Correct Terminology codes to Bibliographic ones
Bug 20482: Correct Terminology codes to Bibliographic ones Bug 20482: (QA follow-up) Correct code in atomic update |
Description
Mark Tompsett
2018-03-28 02:32:53 UTC
Created attachment 73361 [details] [review] Bug 20482: Correct Terminology codes to Bibliographic ones "RELATIONSHIP TO ISO 639-2 ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3 code) was based on the MARC Code List for Languages and published in 1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the bibliographic code is the same as the MARC code." (http://www.loc.gov/marc/languages/introduction.pdf) This leads me to believe that eus, mri, and sqi are incorrect. The slk code was corrected on an earlier bug. TEST PLAN ---------- Apply patch Do a database upgrade -- Are eus, mri, and sqi fixed? reset_all -- Are eus, mri, and sqi never there in the first place? koha qa test tools only check perl code. Created attachment 74654 [details] [review] Bug 20482: Correct Terminology codes to Bibliographic ones "RELATIONSHIP TO ISO 639-2 ISO 639-2 (Codes for the representation of names of languages-- Part 2: alpha-3 code) was based on the MARC Code List for Languages and published in 1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the bibliographic code is the same as the MARC code." (http://www.loc.gov/marc/languages/introduction.pdf) This leads me to believe that eus, mri, and sqi are incorrect. The slk code was corrected on an earlier bug. TEST PLAN ---------- Apply patch Do a database upgrade -- Are eus, mri, and sqi fixed? reset_all -- Are eus, mri, and sqi never there in the first place? koha qa test tools only check perl code. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 74655 [details] [review] Bug 20482: (QA follow-up) Correct code in atomic update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Trivial, passing QA Pushed to master for 18.05, thanks to everybody involved! |