Bug 20497

Summary: LibraryThing: always use https instead of http
Product: Koha Reporter: Kyle M Hall <kyle>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 17137    
Attachments: Bug 20497: Access LibraryThing assets using HTTPS
Bug 20497: Access LibraryThing assets using HTTPS
Bug 20497: Access LibraryThing assets using HTTPS

Description Kyle M Hall 2018-03-29 16:51:15 UTC
As per bug 17137, we should be using SSL for all external resources.
Comment 1 Kyle M Hall 2018-03-29 16:54:50 UTC
We should remove the http option for librarything urls. Apparently it is failing under plack and there is no reason to not always use https.
Comment 2 Tomás Cohen Arazi 2018-03-29 19:13:26 UTC
Created attachment 73443 [details] [review]
Bug 20497: Access LibraryThing assets using HTTPS
Comment 3 Kyle M Hall 2018-03-30 09:43:44 UTC
Created attachment 73458 [details] [review]
Bug 20497: Access LibraryThing assets using HTTPS

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2018-03-30 10:37:42 UTC
Created attachment 73460 [details] [review]
Bug 20497: Access LibraryThing assets using HTTPS

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-04-02 21:15:47 UTC
Pushed to master for 18.05, thanks to everybody involved!