Bug 20510

Summary: Remove unused sub TotalPaid from C4::Stats
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Architecture, internals, and plumbingAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: martin.renvoize, mtompset
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18643, 20225    
Bug Blocks:    
Attachments: Bug 20510: Remove unused sub TotalPaid from C4::Stats
Bug 20510: Remove unused sub TotalPaid from C4::Stats
Bug 20510: Remove unused sub TotalPaid from C4::Stats

Description Josef Moravec 2018-04-03 06:24:31 UTC
The sub TotalPaid from module C4::Stats is not used anywhere and it should be removed.
Comment 1 Josef Moravec 2018-04-03 06:33:05 UTC
Created attachment 73545 [details] [review]
Bug 20510: Remove unused sub TotalPaid from C4::Stats

Test plan:
0) Do not apply the patch
1) Run git grep TotalPaid and confirm it is only defined and then used once in a test
2) Apply the patch
3) git grep TotalPaid should return nothing
4) prove t/db_dependent/Stats.t should be green
Comment 2 Mark Tompsett 2018-04-04 16:40:12 UTC
Went back to 3.22.x to see what used it.
git log -- reports/
hunted for the stats.print and stats.screen.
Added dependencies which have already been pushed.
Comment 3 Mark Tompsett 2018-04-04 16:44:35 UTC
Created attachment 73653 [details] [review]
Bug 20510: Remove unused sub TotalPaid from C4::Stats

Test plan:
0) Do not apply the patch
1) Run git grep TotalPaid and confirm it is only defined and then used once in a test
2) Apply the patch
3) git grep TotalPaid should return nothing
4) prove t/db_dependent/Stats.t should be green

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 4 Katrin Fischer 2018-04-05 05:38:55 UTC
Created attachment 73671 [details] [review]
Bug 20510: Remove unused sub TotalPaid from C4::Stats

Test plan:
0) Do not apply the patch
1) Run git grep TotalPaid and confirm it is only defined and then used once in a test
2) Apply the patch
3) git grep TotalPaid should return nothing
4) prove t/db_dependent/Stats.t should be green

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2018-04-05 17:54:58 UTC
Pushed to master for 18.05, thanks to everybody involved!