Bug 20539

Summary:	Warnings in catalogue/search.pl need to be removed
Product:	Koha	Reporter:	Jonathan Druart <jonathan.druart>
Component:	Architecture, internals, and plumbing	Assignee:	Julian Maurice <julian.maurice>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	julian.maurice, martin.renvoize, nick, roch.damour
Version:	unspecified
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	19995
Bug Blocks:
Attachments:	Bug 20539: Remove warnings in catalogue/search.pl Bug 20539: Remove warnings in catalogue/search.pl Bug 20539: Remove warnings in catalogue/search.pl

Description Jonathan Druart 2018-04-06 18:02:03 UTC

Use of uninitialized value $template_type in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 273.
Use of uninitialized value $limit_cgi in split at /home/vagrant/kohaclone/catalogue/search.pl line 496.
Use of uninitialized value $total in addition (+) at /home/vagrant/kohaclone/catalogue/search.pl line 541.
Use of uninitialized value $limit_cgi_not_availablity in substitution (s///) at /home/vagrant/kohaclone/catalogue/search.pl line 590.
Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706.
Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706.
Use of uninitialized value $gotopage in pattern match (m//) at /home/vagrant/kohaclone/catalogue/search.pl line 711.

Comment 1 Julian Maurice 2018-04-09 09:49:21 UTC

Created attachment 73849 [details] [review]
Bug 20539: Remove warnings in catalogue/search.pl

Test plan:
1. Start a search from intranet
2. See several warnings in logs
3. Apply patch (&& reload starman)
4. Start a new search
5. Confirm that warnings are gone and that the search still works

Comment 2 Roch D'Amour 2018-04-13 18:20:15 UTC

Created attachment 74176 [details] [review]
Bug 20539: Remove warnings in catalogue/search.pl

Test plan:
1. Start a search from intranet
2. See several warnings in logs
3. Apply patch (&& reload starman)
4. Start a new search
5. Confirm that warnings are gone and that the search still works

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>

Comment 3 Josef Moravec 2018-04-14 08:47:59 UTC

Created attachment 74181 [details] [review]
Bug 20539: Remove warnings in catalogue/search.pl

Test plan:
1. Start a search from intranet
2. See several warnings in logs
3. Apply patch (&& reload starman)
4. Start a new search
5. Confirm that warnings are gone and that the search still works

Signed-off-by: Roch D'Amour <roch.damour@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Comment 4 Jonathan Druart 2018-04-16 17:12:59 UTC

Pushed to master for 18.05, thanks to everybody involved!

Comment 5 Nick Clemens (kidclamp) 2018-05-22 10:01:00 UTC

Cannot recreate in 17.11