| Summary: | Wrong comment in database documentation for items.itemnotes | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | Developer documentation | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | fridolin.somers, josef.moravec, lucas, m.de.rooy, martin.renvoize, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 20544: Wrong comment database documentation on itemnotes
Bug 20544: Wrong comment database documentation on itemnotes Bug 20544: Wrong comment database documentation on itemnotes |
||
Created attachment 84941 [details] [review] Bug 20544: Wrong comment database documentation on itemnotes Fixes the comments in kohastructure.sql to state the right MARC21 fields for itemnotes (public and internal). To test: - Create a new Koha database and make sure it still installs - Read the patch and check comments are correct Created attachment 85020 [details] [review] Bug 20544: Wrong comment database documentation on itemnotes Fixes the comments in kohastructure.sql to state the right MARC21 fields for itemnotes (public and internal). To test: - Create a new Koha database and make sure it still installs - Read the patch and check comments are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another good catch and the updated text in the patch makes sense to me.. Signing off Created attachment 85025 [details] [review] Bug 20544: Wrong comment database documentation on itemnotes Fixes the comments in kohastructure.sql to state the right MARC21 fields for itemnotes (public and internal). To test: - Create a new Koha database and make sure it still installs - Read the patch and check comments are correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 backported to 18.05.x for 18.05.11 |
kohastructure.sql has a wrong comment on items.itemnotes, claiming it is MARC21 952$x, when it should be 952$z kohastructure.sql: `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$x) marc21_framework_DEFAULT.sql: ('952', 'x', 'Non-public note', 'Non-public note', 0, 0, 'items.itemnotes_nonpublic' ...