Summary: | usage() function in cleanup_database.pl needs refactoring | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <barton> |
Component: | Developer documentation | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, ldjamison |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Barton Chittenden
2018-04-10 15:11:50 UTC
Barton, have a suggestion on how it should be re-written? (In reply to Lee Jamison from comment #1) > Barton, have a suggestion on how it should be re-written? In terms of documenting the '-m' option: I would change the GetOptions call from 'm|mail:i' => \$mail, to 'm|messageque:i' => \$mail, 'mail:i' => sub { $mail = shift; warn "Option '--mail' is deprecated. " . "use --messagequeue instead"; }, There may be better ways of handling the deprecated options, I welcome feedback from QA. Then the actual message should be something like this: '-m --messagequeue DAYS: Delete rows from message queue after DAYS days.' '--mail DAYS: (Deprecated) Delete rows from message_queue after DAYS days. This option is deprecated and will issue a warning if used. Use --messagequeue DAYS instead.' In terms of re-writing the usage() function to use pod2usage, take a look at misc/cronjobs/longoverdue.pl, it covers several common ways to call pod2usage. |