Summary: | Marking ILL request as complete results in "Internal server error" | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Isherwood <bugzilla> |
Component: | ILL | Assignee: | Andrew Isherwood <bugzilla> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P2 | CC: | chloe.hofstede, fridolin.somers, joe.mcglynn, jonathan.druart, m.de.rooy, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 7317 | ||
Bug Blocks: | |||
Attachments: |
Bug [20556] - [Marking ILL request as complete..]
Bug [20556] - [Marking ILL request as complete..] Bug 20556: Marking ILL request as complete.. |
Description
Andrew Isherwood
2018-04-10 15:49:08 UTC
Created attachment 73957 [details] [review] Bug [20556] - [Marking ILL request as complete..] When marking a request as complete, the status is updated internally then the user to redirected to the view of the request. Although the redirect header is sent, there is no exit to indicate that the program flow should stop. As a result, an attempt is made to render the template, which fails. This patch simply adds the missing exit. TEST PLAN --------- - Create an ILL request - "Manage request" > "Confirm request" - "Mark completed" - TEST: Ensure that no error is written to the error log upon clicking "Mark completed" Plack is standard and pretty much non-optional, updating severity. Created attachment 74041 [details] [review] Bug [20556] - [Marking ILL request as complete..] When marking a request as complete, the status is updated internally then the user to redirected to the view of the request. Although the redirect header is sent, there is no exit to indicate that the program flow should stop. As a result, an attempt is made to render the template, which fails. This patch simply adds the missing exit. TEST PLAN --------- - Create an ILL request - "Manage request" > "Confirm request" - "Mark completed" - TEST: Ensure that no error is written to the error log upon clicking "Mark completed" Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> QA: Looking here Commit message complaint ;) Do not use Bug [20556] - [Marking ILL request as complete..] but use Bug 20556: Marking ILL request as complete.. In short no brackets + hypen but a semicolon! No fail for now, but things change when repeated heavily. Note that the commit message could be more explicit like Add exit when completing ILL request or so? Created attachment 74598 [details] [review] Bug 20556: Marking ILL request as complete.. When marking a request as complete, the status is updated internally then the user to redirected to the view of the request. Although the redirect header is sent, there is no exit to indicate that the program flow should stop. As a result, an attempt is made to render the template, which fails. This patch simply adds the missing exit. TEST PLAN --------- - Create an ILL request - "Manage request" > "Confirm request" - "Mark completed" - TEST: Ensure that no error is written to the error log upon clicking "Mark completed" Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.6 |