Summary: | Occurrences of loading-small.gif still exist | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 16072 | ||
Bug Blocks: | |||
Attachments: |
Bug 20559: Occurrences of loading-small.gif still exist
Bug 20559: Compiled CSS Bug 20559: Occurrences of loading-small.gif still exist Bug 20559: Compiled CSS Bug 20559: Occurrences of loading-small.gif still exist Bug 20559: Compiled CSS |
Description
Jonathan Druart
2018-04-10 20:38:13 UTC
Created attachment 76385 [details] [review] Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. Created attachment 76386 [details] [review] Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. Created attachment 76528 [details] [review] Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76529 [details] [review] Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76543 [details] [review] Bug 20559: Occurrences of loading-small.gif still exist This patch removes some leftover references to a file which no longer exists. In the OPAC, loading-small.gif was included in CSS which was never used. In the staff client, loading-small.gif should have been corrected to spinner-small.gif. To test, apply the patch and go to Tools -> Batch record modification. - Submit a batch of records to modify - In the table of titles which will be modified, click the 'Show MARC' button. - The modal preview window should show "Loading" and an animated spinner before the MARC record is loaded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 76544 [details] [review] Bug 20559: Compiled CSS This patch contains the compiled OPAC CSS. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.02 Patch "Compiled CSS" does not apply on 17.11.x. Sorry I have never used this compilation. Must I run it or do we not back-port such patches ? (In reply to Fridolin SOMERS from comment #9) > Patch "Compiled CSS" does not apply on 17.11.x. You should only apply the first one then regenerate the .css > Sorry I have never used this compilation. There is a wiki page, search for "lessc" > Must I run it or do we not back-port such patches ? You are the Rmaint ;) IMO it's "just" a loading icon, not really important. (In reply to Jonathan Druart from comment #10) > (In reply to Fridolin SOMERS from comment #9) > > Patch "Compiled CSS" does not apply on 17.11.x. > > You should only apply the first one then regenerate the .css > > > Sorry I have never used this compilation. > > There is a wiki page, search for "lessc" > > > Must I run it or do we not back-port such patches ? > > You are the Rmaint ;) > IMO it's "just" a loading icon, not really important. Ok thanks a lot. I prefer to skip this time since its minor. Not pushed to 17.11.x |