Summary: | Using "Edit serials" with no issues selected gives an ugly error | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Serials | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, martin.renvoize, severine.queune |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 20616: Prevent "edit serials" form submission if no serial is selected
Bug 20616: Prevent "edit serials" form submission if no serial is selected Bug 20616: Prevent "edit serials" form submission if no serial is selected Bug 20616: (QA follow-up) Make alert translatable |
Description
Katrin Fischer
2018-04-19 06:39:10 UTC
Created attachment 74766 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Created attachment 74768 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Warning popup is better than an error page :) Thank you Cait ! It was Jonathan's work :) Created attachment 74772 [details] [review] Bug 20616: Prevent "edit serials" form submission if no serial is selected In order to prevent the form to submit and gives an ugly error if no issues are selected we will make sure at least one is checked otherwise an alert will be displayed. Test plan: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 74773 [details] [review] Bug 20616: (QA follow-up) Make alert translatable (In reply to Katrin Fischer from comment #4) > It was Jonathan's work :) oups... Thank you Cait for pointing this issue, and Jonathan for solving it ! You're a great team. Pushed to master for 18.05, thanks to everybody involved! Pushed to 17.11.x for 17.11.11 |