Bug 20620

Summary: Warning in moredetail.pl need to be removed
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: m.de.rooy, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 19995    
Bug Blocks:    
Attachments: Bug 20620: Remove warnings in moredetail.pl
Bug 20620: Remove warnings in moredetail.pl
Bug 20620: Remove warnings in moredetail.pl

Description Jonathan Druart 2018-04-19 12:44:06 UTC
Use of uninitialized value in hash element at /home/vagrant/kohaclone/catalogue/moredetail.pl line 126.
Use of uninitialized value in sprintf at /home/vagrant/kohaclone/catalogue/moredetail.pl line 127.
Use of uninitialized value in sprintf at /home/vagrant/kohaclone/catalogue/moredetail.pl line 127.
Use of uninitialized value in sprintf at /home/vagrant/kohaclone/catalogue/moredetail.pl line 137.
Use of uninitialized value in sprintf at /home/vagrant/kohaclone/catalogue/moredetail.pl line 137.
Comment 1 Jonathan Druart 2018-04-19 12:56:50 UTC
Created attachment 74548 [details] [review]
Bug 20620: Remove warnings in moredetail.pl

Since 19995 warnings are displayed in moredetail.pl, we should get rid
of them.

Test plan:
Hit moredetail.pl with different biblionumbers and confirm you do no
longer see warnings in logs.

Make sure values for rentalcharge, item type, ccode and replacementprice
are displayed correctly.
Comment 2 Bouzid Fergani 2018-04-20 19:50:30 UTC
Created attachment 74659 [details] [review]
Bug 20620: Remove warnings in moredetail.pl

Since 19995 warnings are displayed in moredetail.pl, we should get rid
of them.

Test plan:
Hit moredetail.pl with different biblionumbers and confirm you do no
longer see warnings in logs.

Make sure values for rentalcharge, item type, ccode and replacementprice
are displayed correctly.

Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Comment 3 Marcel de Rooy 2018-05-04 09:41:46 UTC
Created attachment 75057 [details] [review]
Bug 20620: Remove warnings in moredetail.pl

Since 19995 warnings are displayed in moredetail.pl, we should get rid
of them.

Test plan:
Hit moredetail.pl with different biblionumbers and confirm you do no
longer see warnings in logs.

Make sure values for rentalcharge, item type, ccode and replacementprice
are displayed correctly.

Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Jonathan Druart 2018-05-04 12:50:28 UTC
Pushed to master for 18.05, thanks to everybody involved!