| Summary: | Add some color to bootstrap modal headers and footers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Before
After Bug 20622: Add some color to bootstrap modal headers and footers Bug 20622: Add some color to bootstrap modal headers and footers Bug 20622: Add some color to bootstrap modal headers and footers |
||
|
Description
Kyle M Hall (khall)
2018-04-19 13:57:17 UTC
Created attachment 74557 [details]
Before
Created attachment 74558 [details]
After
Created attachment 74559 [details] [review] Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color Because of the way the modal is styled, changing the background color this way has a side-effect of eliminating the rounded corners on the modal. Since this wasn't an explicit choice I'm going to suggest an alternative:
On line 2674:
.modal-body {
background-color: #FFF;
overflow-y: auto;
}
.modal-content {
background-color : #EDF4F6;
}
Created attachment 74606 [details] [review] Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> That looks perfect! Thanks Owen. I authored the patch in your name and added my sign-off to it! (In reply to Owen Leonard from comment #4) > Because of the way the modal is styled, changing the background color this > way has a side-effect of eliminating the rounded corners on the modal. Since > this wasn't an explicit choice I'm going to suggest an alternative: > > On line 2674: > > .modal-body { > background-color: #FFF; > overflow-y: auto; > } > > .modal-content { > background-color : #EDF4F6; > } Created attachment 74694 [details] [review] Bug 20622: Add some color to bootstrap modal headers and footers Right now the bootstrap modal header, body and footer are all white. It would be nice to give them a bit of color. Test Plan: 1) Apply this patch 2) Find a patron, click the 'add message' button 3) Note the modal header and footer now have a background color Signed-off-by: Kyle M Hall <kyle@bywatetsolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 18.05, thanks to everybody involved! |