| Summary: | When ILL is enabled the hover effect on the ILL requests button is wrong. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | gmcharlt, nick, oleonard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 7317 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 20647: Correct hover effect for Ill module
Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong Screenshot showing updated staff client home page Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong |
||
|
Description
Martin Renvoize (ashimema)
2018-04-24 10:02:13 UTC
Created attachment 75456 [details] [review] Bug 20647: Correct hover effect for Ill module Created attachment 75785 [details] [review] Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Created attachment 75786 [details]
Screenshot showing updated staff client home page
Looks much nicer than my fix [U+1F600]. Comment on attachment 75456 [details] [review] Bug 20647: Correct hover effect for Ill module Obsoleting my patch.. Owens is much nicer.. :) Created attachment 76557 [details] [review] Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signing off, works as expected.. :) Created attachment 77190 [details] [review] Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong This alternate patch adds a new icon to the sprite image which gives icons to the link on the staff client home page. It modifies the CSS positioning for all the links as the new image sprite is somewhat different. The SVG file from which the sprite image was generated is also updated, and the about page has been updated to give credit to the creator of the icon. Unrelated change: The cataloging link is moved to the second column. Although it's probably rare for all modules to be enabled and available, this puts the same number of links in each column. To test, apply the patch and clear your browser cache if necessary. With interlibrary loan enabled, view the staff client home page and confirm that all the module links look correct, including when you hover your mouse over them. Confirm that the about page lists the new icon under the "licenses" tab. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Awesome work all! Pushed to master for 18.11 I chose to treat this as a bugfix as it fixes incorrect behaviour. Pushed to 18.05.x for 18.05.03 |